Standardise project structure for the Pallets Ecosystem #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdur-rahmaanJ
approved these changes
Jul 8, 2024
@Abdur-rahmaanJ The only thing that seems to need fixing is typing. If the library isn't ready for typing checks, the test should be disabled, and a ticket should be created to add type support. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies across, and then customises, the Pallets Ecosystem standard project structure from Flask-DebugToolbar
The tests throw a number of warnings, which are now being flagged as errors because of the standard project config. I've suppressed a number of these where it feels appropriate, but probably worth discussing if it's right to suppress them here or if we should immediately fix them. I suspect a number of them should be addressed in separate issues, eg things around DeprecationWarnings.
The test requirements file is a lot more complex for this project than for FDT, so I'm not sure we can freeze it in the same way. I have kept a
tests.infile, with the existingtest_requiresfrom the originalsetup.py; not sure what we would want to do about this.I suspect we may also need to disable the
typingcheck and address that in a separate PR.fixes: #2435